Feat/add common labels#62
Conversation
e801618 to
5d58f04
Compare
- Adds support for custom global labels for guac stack - Adds tests for custom labels Signed-off-by: Gagan H R <ghr@guidewire.com> Co-Authored-By: Anirudh Edpuganti <68942952+ANIRUDH-333@users.noreply.github.com> Co-Authored-By: Ayush Shyam Kumar <65535504+ayush-shyam-kumar@users.noreply.github.com> Co-Authored-By: shreyas pandya <1439158+shreyasHpandya@users.noreply.github.com>
5d58f04 to
e769232
Compare
|
From @ANIRUDH-333 in Slack:
|
|
Thanks @ANIRUDH-333 for the PR. The guac.labels helper function was intended for your use case and it should be included in all resources - https://github.com/kusaridev/helm-charts/blob/main/charts/guac/templates/_helpers.tpl#L38-L48 api-only-ingress.yaml:15:{{- include "guac.labels" . | nindent 4 }} Perhaps move your guac.customLabels into guac.common.labels and drop a conditional and reference in guac.labels? |
|
Thanks, @sunnyyip, this is a better approach, we will try to make these changes and update the PR |
Contribution towards adding custom labels to all the guac resources